Thanks for opening this PR! :)
Please sign off your commit: https://stackoverflow.com/questions/1962094/what-is-the-sign-off-feature-in-git-for

This seems to work okay when the confirm-traffic-increase hook returns successfully at the very start of the analysis and then returns an error later during the analysis. But it doesn't work as expected if the confirm-traffic-increase hook returns an error at the very first iteration.
In this case, we never progress the canary forward (since the hook returned an error) and set the Canary's phase to WaitingTrafficIncrease while the canary weight is still 0, so in the next iterations, we just keep running the metric checks, which return an error since no traffic has reached the canary yet.

Now, if after a few iterations, the confirm-traffic-increase hook returns successfully, the analysis doesn't proceed as expected. This is due to the fact that instead of progressing the canary forward and consequently increasing the canary weight up from zero, we keep running the metric checks, which again return an error because no traffic reached the canary ever, leading to:

{"level":"info","ts":"2022-08-24T23:20:27.962+0530","caller":"controller/events.go:45","msg":"Halt podinfo.test advancement waiting for traffic increase approval automata","canary":"podinfo.test"}
{"level":"info","ts":"2022-08-24T23:20:42.948+0530","caller":"controller/events.go:45","msg":"Halt advancement no values found for contour metric request-success-rate probably podinfo.test is not receiving traffic: running query failed: no values found","canary":"podinfo.test"}
{"level":"info","ts":"2022-08-24T23:20:57.948+0530","caller":"controller/events.go:45","msg":"Halt advancement no values found for contour metric request-success-rate probably podinfo.test is not receiving traffic: running query failed: no values found","canary":"podinfo.test"}

Steps to repro:

• Create this Canary:

apiVersion: flagger.app/v1beta1
kind: Canary
metadata:
  name: podinfo
spec:
  analysis:
    interval: 15s
    maxWeight: 50
    metrics:
    - interval: 1m
      name: request-success-rate
      threshold: 99
    - interval: 1m
      name: request-duration
      threshold: 500
    stepWeight: 10
    threshold: 15
    webhooks:
    - name: automata
      timeout: 5s
      type: confirm-traffic-increase
      url: http://<flagger-loadtester-url>/gate/check
    - metadata:
        cmd: hey -z 1m -q 5 -c 2 -host app.example.com http://envoy.projectcontour
        logCmdOutput: "true"
        type: cmd
      name: load-test
      timeout: 5s
      url: http://<flagger-loadtster-url>
  progressDeadlineSeconds: 60
  provider: contour
  service:
    port: 80
    targetPort: 9898
  targetRef:
    apiVersion: apps/v1
    kind: Deployment
    name: podinfo

• Close the gate:

curl -v -X POST --data '{"type": "confirm-traffic-increase", "name": "podinfo", "namespace": "test", "phase": "Initialized"}' http://<flagger-loadtester-url>/gate/close

• Kick off the analysis: kubectl -n test set image deploy/podinfo podinfod==ghcr.io/stefanprodan/podinfo:6.0.1
• Wait for the first couple of iterations and then open the gate:

 curl -v -X POST --data '{"type": "confirm-traffic-increase", "name": "podinfo", "namespace": "test", "phase": "WaitingTrafficIncrease"}' http://<flagger-loadtester-url>/gate/open

Please let me know if I'm unclear and you want me to elaborate further :)